Skip to content

binary_search_traversals.py made memory-friendly using generators. Fixes #8725 completely. #9237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 1, 2023
Merged

binary_search_traversals.py made memory-friendly using generators. Fixes #8725 completely. #9237

merged 4 commits into from
Oct 1, 2023

Conversation

aryan1165
Copy link
Contributor

Describe your change:

Fixes #8725.
PR #9208 made some changes to binary_tee_traversal.py. This is an extension to that as it extends same method (Generator-based traversal) to other three functions also.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files merge conflicts Open a new PR or rebase on the latest commit awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@algorithms-keeper algorithms-keeper bot removed the merge conflicts Open a new PR or rebase on the latest commit label Oct 1, 2023
@aryan1165 aryan1165 mentioned this pull request Oct 1, 2023
Merged
14 tasks
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 1, 2023
@aryan1165 aryan1165 changed the title Made every traversal in binary_tree_traversal.py use lazy approach. Fixes #8725. binary_search_traversals.py made memory-friendly using generators. Fixes #8725 completely. Oct 1, 2023
@tianyizheng02 tianyizheng02 merged commit 18cdbc4 into TheAlgorithms:master Oct 1, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@aryan1165 aryan1165 deleted the fixes_#8725 branch October 1, 2023 16:55
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@aryan1165 @sedatguzelsemme
binary_search_traversals.py made memory-friendly using generators. F…
8794e63 
…ixes TheAlgorithms#8725 completely. (TheAlgorithms#9237)

* Made binary tree memory-friendly using generators based travels. Fixes
TheAlgorithms#8725

* Made binary tree memory-friendly using generators based travels. Fixes
TheAlgorithms#8725

* Fixed pre-commit errors
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Making binary tree traversals lazy.
2 participants
@aryan1165 @tianyizheng02